feat(lint/useIsNan): add code fix action #125
Merged
+535
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-Linter
victor-teles
changed the title
victor-teles
force-pushed
the
feature/use-is-nan-fix
branch
from
fce5ad2
to
5b52579
Compare
ematipico
reviewed
Sep 3, 2023
crates/rome_js_analyze/tests/specs/correctness/useIsNan/invalid.js.snap
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/tests/specs/correctness/useIsNan/invalid.js.snap
Outdated
Show resolved
Hide resolved
victor-teles
temporarily deployed
to
Website deployment
GitHub Actions
Inactive
victor-teles
temporarily deployed
to
Website deployment
GitHub Actions
Inactive
victor-teles
force-pushed
the
feature/use-is-nan-fix
branch
from
eed2aaf
to
2064586
Compare
victor-teles
temporarily deployed
to
Website deployment
GitHub Actions
Inactive
victor-teles
temporarily deployed
to
Website deployment
GitHub Actions
Inactive
ematipico
approved these changes
Sep 5, 2023
crates/rome_js_analyze/src/semantic_analyzers/correctness/use_is_nan.rs
Outdated
Show resolved
Hide resolved
victor-teles
temporarily deployed
to
Website deployment
GitHub Actions
Inactive
|
Rebasing the PR should make the CI pass |
victor-teles
force-pushed
the
feature/use-is-nan-fix
branch
from
511e186
to
129d33a
Compare
added 7 commits
September 9, 2023 16:10
victor-teles
force-pushed
the
feature/use-is-nan-fix
branch
from
129d33a
to
0c0b00e
Compare
|
Time to merge 🚀. Thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #96
Provide code fix for useIsNaN rule:
Should this rule support other operators like > < >= <=?
Test Plan